update exclude list for fips #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a mentioned test from openj9. |
pshipton
approved these changes
Dec 12, 2022
|
@WilburZjh your commit is not signed and is failing the check. Pls update the commit with a Signed-off-by. |
Signed-off-by: Jinhang Zhang <Jinhang.Zhang@ibm.com>
WilburZjh
force-pushed
the
excludeList4
branch
from
50a673b
to
230584b
Compare
|
updated |
|
It doesn't look like there is a blank line between the title and the Signed-off-by line. There should be a blank line before the Signed-off-by. |
|
Ok, I see there is a blank line, it's just not obvious when looking via github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes eclipse-openj9/openj9#16412